-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGNode Attribute Getters and Setters #70
base: master
Are you sure you want to change the base?
Conversation
Wanted to put this pull request up for some initial review and feedback. I'm also planning to give it a thorough self-review this week and will likely make some small changes. |
Sorry, a bit busy, will look at it next week |
No worries! I know it's a big change to submit all at once, so please don't feel like you have to rush to review it. |
Looks great to me, would be happy to have it. How about having a Scene demonstrating some of these new APIs? Maybe not all, but just a few? |
Sounds good, I'll add a scene later this week. |
From quick overview, I would love to see:
|
Right now, I don't think it's possible to pass in currentColor from the outer world. I would have to add additional bindings for That being said I've messed around with dynamically changing the root nodes fill color (which is inherited by the rest of the SVG) and making a scene that changes it on hover should be easy. |
Yeah let’s do that. The idea is to demonstrate/test what is available |
Bindings for the assorted attribute getters and setters on SkSVGNode.